fix maven dependencies version #5930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bogdan Sava <[email protected]>
Signed-off-by: Bogdan Sava <[email protected]>
Signed-off-by: Bogdan Sava <[email protected]>
Signed-off-by: Bogdan Sava <[email protected]>
bogdan-sava
requested review from
mandy-chessell and
planetf1
as code owners
Signed-off-by: Bogdan Sava <[email protected]>
lpalashevski
approved these changes
Nov 16, 2021
planetf1
requested changes
Nov 16, 2021
There was a problem hiding this comment.
@bogdan-sava Can you describe the scenario to demonstrate the original problem - is there a linked issue?
Here I see we are:
- Adding a new dependency for the graph repo connector (scope=compile)
- Adding an exception for our dependency checker (which normally is only needed for scope=runtime)
- Adding spring-boot-starter-validation to server chassis & ui chassis (with exception, but this is normal for spring boot as it's typically runtime)
This has resulted in needing the older hibernate version -- if we have to go with it that's fine - though we should check for outstanding CVEs. But I'd like to also understand the mechanics as I believe the code works as-is with maven, but the problem you are addressing only manifests itself in the intelliJ environment (which is also important to document/have working)
I understand there was an initial loading issue - am I correct that all the above changes were specifically to address this? Is there a reason the ui-chassis is affected since it does not load connectors?
|
The issue is that while configure IntelliJ with additional maven dependency for running server-chassis-spring with graph-repository-connector, fails with: Main problem is that |
|
This is happening because IntelliJ is running the OMAGServerPlatform main class with the following command: You can run it like this in command line, with same result. But as you can see the hibernate-validator version is 4.3.0. |
|
The dependency can be runtime. Is it help with check? |
|
@bogdan-sava @planetf1 I wondered whether an equivalent change needs to be made to gradle or is this not an issue for the gradle build? |
|
I am proposing to continue the discussion and the review on the security call and see if there is need to threat some aspects proposed by this change separately. |
planetf1
approved these changes
Nov 18, 2021
There was a problem hiding this comment.
I approve and recommend merging :
- you’ve done investigation of a specific problem with the connector and also looked at the general way things work
- It addresses a real problem for you & the team
- There is a PR ready to go
- I’ve not identified a specific issue during the review - just a feeling of some oddities in IntelliJ/mvn but which could be my understanding. I don’t have any evidence of a problem written up (other than a minor backleveling)
- even if there were to be issues, this doesn't make things any worse.
- There is no justification for further delay.
- Therefore we merge.
- Then, let’s see how it goes.. we still have a week or two in the release. More people will have exposure.
If/when I can document a clear broken path (there may not be one …) I will raise a new issue and we’ll take it from there based on that specific evidence
Approve.
|
@davidradl ideally we should get gradle to parity - but the gradle build still needs a concerted effort to get to parity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
server-chassis-spring is not working started in IntelliJ by adding intellij runtime dependency.
:graph-repository-connector brings
:hibernate-validator:4.2.0via:janusgraph-cql->:cassandra-all->:reporter-config3This version of hibernate-validator is not compatible with spring-boot
Fixed by controlling hibernate-validator version through dependency management